Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NoopTimer#time(Runnable) should run the Runnable #4540

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

joschi
Copy link
Member

@joschi joschi commented Oct 21, 2024

Fixes #4536

@joschi joschi added the bug label Oct 21, 2024
@joschi joschi added this to the 4.2.29 milestone Oct 21, 2024
@joschi joschi self-assigned this Oct 21, 2024
@joschi joschi requested review from a team as code owners October 21, 2024 21:00
Copy link

@joschi joschi merged commit 4f6fc57 into release/4.2.x Oct 21, 2024
7 checks passed
@joschi joschi deleted the issue-4536-4.2.x branch October 21, 2024 21:44
LuciferYang pushed a commit to apache/spark that referenced this pull request Nov 29, 2024
### What changes were proposed in this pull request?
This pr aims to upgrade `dropwizard metrics` from `4.2.28` to  `4.2.29`.

### Why are the changes needed?
v4.2.128 VS v.4.2.29
dropwizard/metrics@v4.2.28...v4.2.29
dropwizard/metrics#4540

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #48997 from panbingkun/SPARK-50444.

Authored-by: panbingkun <panbingkun@apache.org>
Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoopMetricRegistry.NoopTimer::time(Runnable) should actually run the supplied Runnable
1 participant