Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand Dependency #10

Closed
RamiHg opened this issue Jun 18, 2020 · 2 comments
Closed

rand Dependency #10

RamiHg opened this issue Jun 18, 2020 · 2 comments

Comments

@RamiHg
Copy link

RamiHg commented Jun 18, 2020

Hello,

Kudos on this really interesting crate. It fits my needs quite well! I noticed, however, that this crate depends on rand. I like to keep my dependencies as small as possible, and rand is a particularly heavy crate (112kB!) that has a lot of bells and whistles.

Unless there's a particular need for advanced and cryptographically secure random numbers, would it be possible to drop the dependency on rand? Perhaps a simpler (non-secure) alternative like simplerand could be used. If that's not possible, maybe the random functionality can be hidden behind a feature flag?

Thanks!

@droundy
Copy link
Owner

droundy commented Jun 18, 2020

Using just my phone I don't see where it's needed. I'd welcome a pull request to remove the dependency or if needed change it to a dev-dependency. Or I'll try to get to this within a week or two.

@droundy
Copy link
Owner

droundy commented Jun 19, 2020

Sorry that last comment was false. I forgot that I use random numbers when expanding the hash table in order to give some protection against collision attacks. I doubt we need high quality random numbers for this, and it's not needed at all for many use cases. Maybe a no-rand feature flag would be simplest?

droundy added a commit that referenced this issue Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants