readOnly for ConfigMaps (#48)

* readOnly for ConfigMaps * add Readonly in handler * remove readOnly from types * fix unit test
druid-io · Jul 29, 2020 · 925aaa3 · 925aaa3
1 parent 0372b5d
commit 925aaa3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/pkg/controller/druid/handler.go b/pkg/controller/druid/handler.go
@@ -578,10 +578,12 @@ func makeStatefulSet(nodeSpec *v1alpha1.DruidNodeSpec, m *v1alpha1.Druid, ls map
 		{
 			MountPath: firstNonEmptyStr(m.Spec.CommonConfigMountPath, defaultCommonConfigMountPath),
 			Name:      "common-config-volume",
+			ReadOnly:  true,
 		},
 		{
 			MountPath: firstNonEmptyStr(nodeSpec.NodeConfigMountPath, defaultNodeConfigMountPath),
 			Name:      "nodetype-config-volume",
+			ReadOnly:  true,
 		},
 	}
 

diff --git a/pkg/controller/druid/testdata/broker-statefulset.yaml b/pkg/controller/druid/testdata/broker-statefulset.yaml
@@ -8,7 +8,7 @@ metadata:
   name: druid-druid-test-brokers
   namespace: test-namespace
   annotations:
-    druidOpResourceHash: JvDKxq3cBaf0FBXMscfcQ/RXrcs=
+    druidOpResourceHash: OnEopGbFnwSCMqd84ePrk0Kvd9o=
 spec:
   podManagementPolicy: Parallel
   replicas: 2
@@ -59,10 +59,13 @@ spec:
             memory: 2Gi
         volumeMounts:
         - mountPath: /druid/conf/druid/_common
+          readOnly: true
           name: common-config-volume
         - mountPath: /druid/conf/druid/broker
+          readOnly: true
           name: nodetype-config-volume
         - mountPath: /druid/data
+          readOnly: true
           name: data-volume
       securityContext:
         fsGroup: 107

diff --git a/pkg/controller/druid/testdata/druid-test-cr.yaml b/pkg/controller/druid/testdata/druid-test-cr.yaml
@@ -159,6 +159,7 @@ spec:
       volumeMounts:
         - mountPath: /druid/data
           name: data-volume
+          readOnly: true
       resources:
         requests:
           memory: "2Gi"