Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Notice #336

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Deprecation Notice #336

merged 2 commits into from
Feb 23, 2023

Conversation

AdheipSingh
Copy link
Contributor

Fixes #XXXX.

Description

This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.
Key changed/added files in this PR
  • MyFoo
  • OurBar
  • TheirBaz

@gianm gianm merged commit 9cec3f2 into druid-io:master Feb 23, 2023
@gianm gianm mentioned this pull request Feb 23, 2023
Closed
@AdheipSingh AdheipSingh mentioned this pull request Feb 27, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianm gianm gianm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdheipSingh @gianm