Add support for 'scan' queries #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
scan_queries
branch
from
b8daf75 to
426aae2
Compare
betodealmeida
approved these changes
Jan 4, 2018
pydruid/query.py
Outdated
| elif self.query_type == "scan": | ||
| nres = [] | ||
| for item in self.result: | ||
| nres += [e for e in item.get('events')] |
There was a problem hiding this comment.
Nit, this can be a single line:
nres = [e for item in self.result for e in item.get('events')]There was a problem hiding this comment.
running out of line width :/, will keep as is
mistercrunch
force-pushed
the
scan_queries
branch
from
426aae2 to
83d08d5
Compare
mistercrunch
force-pushed
the
scan_queries
branch
from
83d08d5 to
6abf99f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.