Reserve original column sequence in SQL when reading data #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reserve original column sequence when reading data from chunk, so that column sequence will be same as what user inputed in SQL.
|
LGTM |
pydruid/db/api.py
Outdated
| @@ -328,7 +328,7 @@ def rows_from_chunks(chunks): | |||
| rows = body[:boundary].lstrip('[,') | |||
| body = body[boundary:] | |||
|
|
|||
| for row in json.loads('[{rows}]'.format(rows=rows)): | |||
| for row in json.loads('[{rows}]'.format(rows=rows), object_pairs_hook=OrderedDict): | |||
There was a problem hiding this comment.
You're getting a "Line too long" linting error that breaks the build.
There was a problem hiding this comment.
Thanks for point out, I have modified the code style to fix the listing error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear,
I found that after pydruid read data, the sequence of columns is different with what user input in SQL,
This patch reserve original column sequence when reading data from chunk, so that column sequence will be same as what user inputed in SQL.
Please help to review this and if possible help to merge this.