-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for filtered aggregator #28
Conversation
Addresses issue #27. |
if kwargs["type"] == "filtered": | ||
kwargs["aggregator"]["name"] = name | ||
else: | ||
kwargs.update({"name": name}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this affects anything, but before, if kwarks already contained a name it would use that instead of overriding it, since we passed the name as the first key/value pair to dict(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm gonna check it, maybe I could also write some tests for this module in order to ensure that the change does not brake compatibility. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, tests would be awesome!
8bdfb38
to
86ebd57
Compare
I updated the pull-request by adding some tests for the filtered aggregator. This branch is rebased on pull-request #32, so this should be done after that. I made two different pull-request so that it is possible to see that no previous behaviour is broken. |
86ebd57
to
385a21a
Compare
Can someone please have a look on this? |
385a21a
to
40e1d1e
Compare
40e1d1e
to
8b8b138
Compare
Rebased on master and fixed test. |
Thanks @se7entyse7en, do you mind signing our CLA before I can merge this? You can do so here http://druid.io/community/cla.html – it also applies to metamx/pydruid |
@xvrl ok! done! |
Added support for filtered aggregator
Adds support for filtered aggregator. Usage example: