support javascript filter #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmckoy do you mind signing the CLA here? druid.io/community/cla.html |
|
@fjy just signed! |
| @@ -67,3 +72,10 @@ def __init__(self, dim): | |||
|
|
|||
| def __eq__(self, other): | |||
| return Filter(dimension=self.dimension, value=other) | |||
|
|
|||
| class Javascript: | |||
There was a problem hiding this comment.
minor nit, in the main Druid repo we typically use JavaScript instead of Javascript in class names
|
👍 @xvrl can we get this in??? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Started using pydruid for some export functionality i needed for some queries. needed to get a little more specific with JS filters and noticed there wasn't support for it. I plopped some code in and it works great locally so i decided to PR my change for review.
This would be syntax for python query:
Let me know if this syntax could improve.
Thanks!