Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for and,or filters with more than 2 values. #46

Merged
merged 1 commit into from
Mar 10, 2016

Conversation

dakra
Copy link
Contributor

@dakra dakra commented Mar 8, 2016

allows filters like filter = Filter(type='or', [Dimension('dim1') == v for v in list_of_values])

@xvrl
Copy link
Member

xvrl commented Mar 8, 2016

👍

allows filters like `filter = Filter(type='or', [Dimension('dim1') == v for v in list_of_values])`
fix druid-io#42: correctly handles filters like `f1 & f2 & f3 & (f4 | f5)`
@dakra
Copy link
Contributor Author

dakra commented Mar 9, 2016

Ah, didn't see the issue or the pull request.
I updated my pull request to correctly handle #42

@fjy
Copy link
Member

fjy commented Mar 9, 2016

@dakra can you fill out CLA if you haven't done it already?
http://druid.io/community/cla.html

@dakra
Copy link
Contributor Author

dakra commented Mar 9, 2016

👍 done

@mcorbe
Copy link

mcorbe commented Mar 9, 2016

@dakra: Forgot to mention that x needs to be tested as well as self in and / or (#42)

@dakra
Copy link
Contributor Author

dakra commented Mar 9, 2016

and or or are left associative so if the left filter (=self) is an and filter already and I and it again with any other filter I just add the right filter to the left filter fields.

maybe I'm missing something obvious or you meant something else?!

@mcorbe
Copy link

mcorbe commented Mar 9, 2016

@dakra sorry my bad, disregard my comment. was only relevant with pull #42.

fjy added a commit that referenced this pull request Mar 10, 2016
add support for `and`,`or` filters with more than 2 values.
@fjy fjy merged commit 621545a into druid-io:master Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants