only import pandas when export_pandas gets called
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| try: | ||
| import pandas | ||
| except ImportError: | ||
| print('Warning: unable to import Pandas. The export_pandas method will not work.') |
There was a problem hiding this comment.
we should change this to be an error instead of a warning in this case, since we are raising an exception
There was a problem hiding this comment.
right.
should I just remove the try-except then?
Think the normal python ImportError: No module names 'pandas' is good enough.
There was a problem hiding this comment.
Now I just moved the import pandas statement from the header to the function.
I think the normal ImportError message is enough and you don't get the
annoying print warning when you don't have pandas installed and don't want to use
the function.
|
Is there any plan om merging this soon? Seems like a no-brainer to me. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess in most production and testing environments pandas is not installed,
so every time you
import pydruidanything you get an (annoying) warning messageprinted even though you never use the
query.export_pandasfunction.This pull moves the import into the function so you only get an error when you
actually call
export_pandas.