Bugfix when building not filter multiple times
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
dakra
force-pushed
the
multi-not-filter
branch
from
75cb42d to
ceb7024
Compare
| actual = filters.Filter.build_filter(~f) | ||
| f = ~filters.Filter(dimension='dim', value='val') | ||
| actual = filters.Filter.build_filter(f) | ||
| actual = filters.Filter.build_filter(f) |
There was a problem hiding this comment.
it would be useful to add a comment to explain why we assign it twice.
Make a copy of `filter` otherwise the `field` value (a :class:`Filter`) of the `not` filter will be replaced with a `dict` and on next call of `build_filter` with the same filter_obj variable will fail.
dakra
force-pushed
the
multi-not-filter
branch
from
ceb7024 to
b09835f
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a copy of
filterotherwise thefieldvalue (a :class:Filter)of the
notfilter will be replaced with adictand on nextcall of
build_filterwith the same filter_obj variable will fail.I didn't write an extra test but just modified the 'not filter test'
to call 2 times
Filter.build_filter.