Add new Greatest and Least post aggregators #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pydruid/utils/postaggregator.py
Outdated
| def __init__(self, fields, output_name=None): | ||
|
|
||
| if output_name is None: | ||
| name = 'doublegreatest' |
There was a problem hiding this comment.
minor nit: using the camel cased name, 'doubleGreatest'
There was a problem hiding this comment.
this applies to other aggregator names also.
These were merged in apache/druid#3567 and will be in the next version of Druid.
erikdubbelboer
force-pushed
the
greatestleast
branch
from
4ed2fca to
5939b8b
Compare
|
Any reason this hasn't been merged? |
erikdubbelboer
added a commit
to atomx/pydruid
that referenced
this pull request
Mar 26, 2017
|
Since this featured has been released with druid 0.10.0 I think this should be merged? |
|
@gianm ? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were merged in apache/druid#3567 and will be in the next version of Druid.