Add min and max aggregators for long and double #84
Conversation
|
Anyone to look at this? |
There was a problem hiding this comment.
Thanks for the contribution!
The patch generally looks good. I left one comment about potentially making things easier for users upgrading. 👍 from me after that.
Could you please also fill out the CLA at http://druid.io/community/cla.html?
| def doublesum(raw_metric): | ||
| return {"type": "doubleSum", "fieldName": raw_metric} | ||
|
|
||
|
|
||
| def min(raw_metric): |
There was a problem hiding this comment.
Could you leave the old ones in for compatibility with older python clients? They should turn into doubleMin and doubleMax since the old min/max aggregators acted like the double versions.
Maybe also add a docstring to the old min/max versions saying they're deprecated.
There was a problem hiding this comment.
Sounds good, I'll do that
|
@gianm thanks for the review. I added back the deprecated methods and also signed the CLA |
This fixes the existing
minandmaxaggregators. Based on the druid docs these should bedoubleMin,doubleMax,longMin, andlongMax.