Hotfix for creating dsn string

druidfi · Aug 24, 2022 · a23a142 · a23a142
1 parent 6623647
commit a23a142
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/Command/DumpCommand.php b/src/Command/DumpCommand.php
@@ -276,24 +276,24 @@ protected function getDefaults($extraFile): array
      */
     protected function getDsn(array $dumpSettings): string
     {
-        $dsn = sprintf('%s:', $dumpSettings['db-type']);
+        $elements = [];
 
         if ($dumpSettings['host']) {
-            $dsn .= sprintf(';host=%s', $dumpSettings['host']);
+            $elements[] = sprintf('host=%s', $dumpSettings['host']);
 
             if ($dumpSettings['port']) {
-                $dsn .= sprintf(';port=%s', $dumpSettings['port']);
+                $elements[] = sprintf('port=%s', $dumpSettings['port']);
             }
         }
         else if ($dumpSettings['socket']) {
-            $dsn .= sprintf(";unix_socket=%s", $dumpSettings['socket']);
+            $elements[] = sprintf('unix_socket=%s', $dumpSettings['socket']);
         }
 
         if ($dumpSettings['db-name']) {
-            $dsn .= sprintf(';dbname=%s', $dumpSettings['db-name']);
+            $elements[] = sprintf('dbname=%s', $dumpSettings['db-name']);
         }
 
-        return $dsn;
+        return sprintf('%s:%s', $dumpSettings['db-type'], join(';', $elements));
     }
 
     protected function getOptOptions($switch): array