improve: LDP-2578: Add getPageLayout helper in useDrupalCe composable #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vloss3
reviewed
Aug 28, 2024
playground/pages/[...slug].vue
Outdated
| useHead({ | ||
| title: page.value.title, | ||
| meta: page.value.metatags.meta, | ||
| link: page.value.metatags.link, | ||
| script: [ | ||
| { | ||
| type: 'application/ld+json', | ||
| children: JSON.stringify(page.value.metatags.jsonld || [], null, ''), | ||
| children: JSON.stringify(page.value.metatags.jsonld || []), |
There was a problem hiding this comment.
reverted this and will commit in ldp-2574
vloss3
reviewed
Aug 28, 2024
| * Determines the page layout based on the Drupal page data. | ||
| * @param page Ref containing the Drupal page data | ||
| * @returns A computed property that resolves to either the page_layout | ||
| * specified in the Drupal data, or 'default' if not specified. |
There was a problem hiding this comment.
maybe remove this empty space/re-write it shorter and one line?
@returns A computed property resolving to the specified page_layout or 'default' if unspecified.
vloss3
changed the title
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/4.0.8/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: Issue #3336148: Add support for forms * LDP-2492: Remove unnecessary if * LDP-2492: Improve redirect code * LDP-2492: Improve internal redirect code * LDP-2492: Revert redirect code * LDP-2492: Improve code and use page middleware * LDP-2492: Add server middleware and error handling * LDP-2492: Move middleware to module * LDP-2492: Include error message commit * LDP-2492: Add imports
vloss3
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.