Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make D9 compatible #12

Open
wants to merge 1 commit into
base: 8.x-1.x
Choose a base branch
from

Conversation

acha5066
Copy link

The RouteEnhancerInterface changes in Drupal 9, so the applies method in the main GraphQL method can no longer be relied upon to check the route.

@sebas5384
Copy link
Collaborator

sebas5384 commented Sep 20, 2020

thanks @acha5066 !

Is it retro compatible with D8? if not I'll have to open a new branch 9.x-1.x, what do you think?

@acha5066
Copy link
Author

acha5066 commented Sep 21, 2020

@sebas5384 I have tested on both 8.8 and 9.0 and it is working so I think it is backwards compatible but more testing is always welcome! There is a similar PR for the main graphql repo drupal-graphql/graphql#1067.
This is the relevant change record in https://www.drupal.org/node/2894934.

@almunnings
Copy link

Works fine with Drupal 8 and Graphql 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants