Introduce extended schema plugin. #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 8.x-4.x #792 +/- ##
===========================================
- Coverage 79.89% 79.3% -0.6%
- Complexity 535 540 +5
===========================================
Files 74 75 +1
Lines 1194 1203 +9
===========================================
Hits 954 954
- Misses 240 249 +9
Continue to review full report at Codecov.
|
klausi
reviewed
May 28, 2019
| use GraphQL\Language\Parser; | ||
| use GraphQL\Utils\SchemaExtender; | ||
|
|
||
| abstract class SdlExtendedSchemaPluginBase extends SdlSchemaPluginBase { |
There was a problem hiding this comment.
we should have a class comment why we need this and what it does.
| * The parsed extended schema document. | ||
| */ | ||
| protected function getExtendedSchemaDocument() { | ||
| // Only use caching of the parsed document if aren't in development mode. |
There was a problem hiding this comment.
"if we aren't in development mode"
|
Sweet, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.