Add extensions dir to Zeitwerk ignore list #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
183-fix-conflict-with-extensions-files
branch
from
ffe0375
to
cfc0bbe
Compare
solnic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to removeextensionsfrom zeitwerk's ignored list and movePrettyPrinttoExtensions::PrettyPrintso that the file structure matches namespaces (otherwise Zeitwerk complains, which is expected).I did not fully track down which specific line caused the original issue, as in, I do not know what refers toExtensionsthat cause auto-loading of that module and not finding anything (sinceextensionswas ignored in the loader config).Anyhow, I reckon this should do it and it doesn't break anything else (famous last words 🤣)So, actually, adding
extensions.rbandextensionsdir did the trick too.Fixes #183