Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge into lmdb #28

Open
kallisti5 opened this issue Feb 3, 2021 · 5 comments
Open

Merge into lmdb #28

kallisti5 opened this issue Feb 3, 2021 · 5 comments
Labels

Comments

@kallisti5
Copy link

Describe the bug
This is one single header wrapped in an entire package. Maybe it should just be merged into lmdb? They accept pull requests.

@kallisti5 kallisti5 added the bug label Feb 3, 2021
@hoytech
Copy link

hoytech commented Feb 3, 2021

Into the LMDB distribution proper, from symas? That is highly unlikely to ever happen, since it's a pure C project and I don't think they're very enthusiastic about C++.

Also, there are multiple C++ wrappers, so who is to say which one becomes the bundled version? I would impudently suggest that my fork of this project (https://github.com/hoytech/lmdbxx) be considered too. :)

@kallisti5
Copy link
Author

Yours is definitely more updated. I'm a package maintainer for Haiku, so trying to figure out which to use for our re-distribution.

@hoytech
Copy link

hoytech commented Feb 4, 2021

In my obviously biased opinion, if you are OK with requiring a C++17 or higher compiler, you should use my fork since it has some important bugfixes.

@kallisti5
Copy link
Author

@hoytech ow. Yours definitely isn't API compatible with this one. Maybe you should have bumped the major version number vs minor :-)

hoytech added a commit to hoytech/lmdbxx that referenced this issue Feb 5, 2021
Increased major version to signify that API has changed from the original fork.

drycpp#28
@hoytech
Copy link

hoytech commented Feb 5, 2021

Good point, sorry about that. Some of the API changes are necessary. I believe removing the templated accessor methods was especially important, they frequently caused bugs.

Anyway I tagged a 1.0.0 release too:

hoytech@029fb68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants