Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from php7.4 to php8.2. #56

Closed
wants to merge 1 commit into from

Conversation

funilrys
Copy link

@funilrys funilrys commented Aug 4, 2023

As php7.4 has reach its end of life 8 months ago, I thought it was time to upgrade.

I tested the change with a compose that looks like the one below. I also tested against some of my private sites and everything worked without any noticeable issue.

WARNING: The data are not persistent with the following compose.

---
version: '2.1'
services:
  gravadmin:
    build:
      context: .
      dockerfile: Dockerfile.gravadmin
      args:
        GRAV_VERSION: 1.7.42.3
    container_name: gravadmin
    restart: unless-stopped
    environment:
      - DUID=1001
      - DGID=1001
      #- GRAV_MULTISITE=subdirectory # optional
      - ROBOTS_DISALLOW=false # optional
    ports:
      - 8080:80
  gravcore:
    build:
      context: .
      dockerfile: Dockerfile.gravcore
      args:
        GRAV_VERSION: 1.7.42.3
    container_name: gravcore
    restart: unless-stopped
    environment:
      - DUID=1001
      - DGID=1001
      #- GRAV_MULTISITE=subdirectory # optional
      - ROBOTS_DISALLOW=false # optional
    ports:
      - 8888:80

CF: https://endoflife.date/php

@dsavell The contribution guidelines page is empty.


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

Indeed, as php7.4 has reach it's end of life 8 month ago, I
thought it's time to upgrade.

CF: https://endoflife.date/php
@funilrys funilrys requested a review from dsavell as a code owner August 4, 2023 18:02
@dsavell
Copy link
Owner

dsavell commented Oct 3, 2023

Heya,

Thank you for your contribution, I have finally been able to get round to getting this image updated.

Please see #65 for these changes I have consolidated.

@dsavell dsavell closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants