Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlTraceFlag: Integration test is missing for this resource #1835

Closed
johlju opened this issue Jan 17, 2023 · 0 comments · Fixed by #1843
Closed

SqlTraceFlag: Integration test is missing for this resource #1835

johlju opened this issue Jan 17, 2023 · 0 comments · Fixed by #1843
Labels
tests The issue or pull request is about tests only.

Comments

@johlju
Copy link
Member

johlju commented Jan 17, 2023

We should add an integration tests for this resource.
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Jan 17, 2023
@johlju johlju mentioned this issue Jan 17, 2023
Closed
@johlju johlju mentioned this issue Jan 25, 2023
Merged
9 tasks
johlju added a commit that referenced this issue Feb 1, 2023
@johlju
SqlTraceFlag: Add integration tests (#1843)
3a46100 
- SqlServerDsc
  - The AppVeyor configuration file was updated to include the possibility
    to run skip installing one or more SQL Server instances when debugging
    in AppVeyor to help maximize the time alloted be run.
- SqlTraceFlag
  - The resource is now tested with an integration tests (issue #1835).
  - A new parameter `ClearAllTraceFlags` was added so a configuration
    can enforce that there should be no trace flags.
  - The examples was updated to show that values should be passed as an array,
    even when there is only one value.
  - `Get-TargetResource` was updated to always return an array for parameter
    `TraceFlags`, `TraceFlagsToInclude`, and `TraceFlagsToInclude`. _The last_
    _two properties will always return an empty array._
  - `Set-TargetResource` was updated to handle a single trace flag in the
    current state (issue #1834).
  - `Set-TargetResource` was updated to correctly include or exclude a single
    flag (issue #1834).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests The issue or pull request is about tests only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlTraceFlag: Add integration tests johlju/SqlServerDsc
1 participant
@johlju