Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: xSQLServerFailoverClusterSetup: Remove deprecated resource #336

Closed
johlju opened this issue Jan 23, 2017 · 1 comment · Fixed by #578
Closed

BREAKING CHANGE: xSQLServerFailoverClusterSetup: Remove deprecated resource #336

johlju opened this issue Jan 23, 2017 · 1 comment · Fixed by #578
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change.

Comments

@johlju
Copy link
Member

johlju commented Jan 23, 2017

This resource is being merged with xSQLServerSetup. When issue #334 has been resolved, then this resource can be removed from this module.
Users that still need it can use it from an old version of xSQLServer. But any new functionality will be added to xSQLServerSetup.
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. on hold The issue or pull request has been put on hold by a maintainer. labels Jan 23, 2017
@johlju
Copy link
Member Author

johlju commented Mar 11, 2017

xSQLServerSetup should now have the functionality of resource xSQLServerFailoverClusterSetup and issue #334 has been resolved. Of course there might be other issues down the line that need to be fixed. But I'm thinking that we can remove resource xSQLServerFailoverClusterSetup from this module now. If somebody need the resource xSQLServerFailoverClusterSetup they then need to continue use v6.0.

Anybody have any objections to this? If you think it is a good idea, please write that as well. 😄

Removing xSQLServerFailoverClusterSetup will be the start to remove all code in xPDT.psm1. After xSQLServerFailoverClusterSetup is removed, we can change the way xSQLServerSetup is starting setup process (currently in PR). When that is done we can remove all code in xPDT.psm1.

@johlju johlju removed the on hold The issue or pull request has been put on hold by a maintainer. label Mar 11, 2017
@johlju johlju changed the title xSQLServerFailoverClusterSetup: Remove deprecated resource BREAKING CHANGE: xSQLServerFailoverClusterSetup: Remove deprecated resource May 21, 2017
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 21, 2017
@johlju
Changes to xSQLServer
27ad7c5 
BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue dsccommunity#336).
@johlju johlju added the in progress The issue is being actively worked on by someone. label May 21, 2017
@johlju johlju self-assigned this May 21, 2017
@johlju johlju mentioned this issue May 25, 2017
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 27, 2017
@johlju
Changes to xSQLServer
f288319 
BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue dsccommunity#336).
johlju added a commit to johlju/SqlServerDsc that referenced this issue May 30, 2017
@johlju
Changes to xSQLServer
d8b6db7 
BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue dsccommunity#336).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 3, 2017
@johlju
Changes to xSQLServer
5453e66 
BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue dsccommunity#336).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 4, 2017
@johlju
Changes to xSQLServer
1a78870 
BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue dsccommunity#336).
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jun 5, 2017
@johlju
Changes to xSQLServer
c3180c9 
BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue dsccommunity#336).
johlju added a commit that referenced this issue Jun 6, 2017
@johlju
BREAKING CHANGE: xSQLServer: Removed deprecated resources and WMF 4.0…
71b5cc4 
… support, xSQLServerSetup supports PsDscRunAsCredential (#578)

- Changes to xSQLServer
  - BREAKING CHANGE: xSQLServer does no longer try to support WMF 4.0 (PowerShell 4.0) (issue #574). Minimum supported version of WMF is now 5.0 (PowerShell 5.0).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupJoin (issue #457).
  - BREAKING CHANGE: Removed deprecated resource xSQLAOGroupEnsure (issue #456).
  - BREAKING CHANGE: Removed deprecated resource xSQLServerFailoverClusterSetup (issue #336).
- Changes to xSQLServerHelper
  - Removed helper function Grant-ServerPerms because the deprecated resource that was using it was removed.
  - Removed helper function Grant-CNOPerms because the deprecated resource that was using it was removed.
  - Removed helper function New-ListenerADObject because the deprecated resource that was using it was removed.
- Changes to xSQLServerSetup
  - BREAKING CHANGE: Replaced StartWin32Process helper function with the cmdlet Start-Process (issue #41, #93 and #126).
  - BREAKING CHANGE: The parameter SetupCredential has been removed since it is no longer needed. This is because the resource now support the built-in PsDscRunAsCredential.
  - BREAKING CHANGE: Now the resource supports using built-in PsDscRunAsCredential. If PsDscRunAsCredential is set, that username will be used as the first system administrator.
  - BREAKING CHANGE: If the parameter PsDscRunAsCredential are not assigned any credentials then the resource will start the setup process as the SYSTEM account. When installing as the SYSTEM account, then parameter SQLSysAdminAccounts and ASSysAdminAccounts must be specified when installing feature Database Engine and Analysis Services respectively.
  - When setup exits with the exit code 3010 a warning message is written to console telling that setup finished successfully, but a reboot is required (partly fixes issue #565).
  - When setup exits with an exit code other than 0 or 3010 a warning message is written to console telling that setup finished with an error (partly fixes issue #580).
  - Added a new parameter SetupProcessTimeout which defaults to 7200 seconds (2 hours). If the setup process has not finished before the timeout value in SetupProcessTimeout an error will be thrown (issue #566).
  - Updated all examples to match the removal of SetupCredential.
  - Updated (removed) severe known issues in README.md for resource xSQLServerSetup.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 6, 2017
@johlju johlju removed their assignment Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change.
Projects
None yet
Milestone
No milestone
1 participant
@johlju