Assert-SetupActionProperties: Use commands from DscResource.Common

[johlju]

Pull Request (PR) description

• SqlServerDsc
  • Removed Test-ServiceAccountRequirePassword from private functions (issue Test-ServiceAccountRequirePassword: Move to DscResource.Common as a public command #1794)
    • Replaced by Test-AccountRequirePassword that was added to DscResource.Common
      public functions (issue #93).
  • Removed Assert-RequiredCommandParameter from private functions (issue Assert-RequiredCommandParameter: Move to DscResource.Common as a public command #1796).
    • Replaced by Assert-BoundParameter (part of DscResource.Common)
      that had a new parameter set added (issue #92).

This Pull Request (PR) fixes the following issues

• Fixes Test-ServiceAccountRequirePassword: Move to DscResource.Common as a public command #1794
• Fixes Assert-RequiredCommandParameter: Move to DscResource.Common as a public command #1796

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation updated in the resource's README.md.
• Resource parameter descriptions updated in schema.mof.
• Comment-based help updated, including parameter descriptions.
• Localization strings updated.
• Examples updated.
• Unit tests updated. See DSC Community Testing Guidelines.
• Integration tests updated (where possible). See DSC Community Testing Guidelines.
• Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1828 (1d80037) into main (1397e58) will decrease coverage by 0%.
The diff coverage is 92%.

@@         Coverage Diff          @@
##           main   #1828   +/-   ##
====================================
- Coverage    91%     91%   -1%     
====================================
  Files        81      79    -2     
  Lines      7428    7410   -18     
====================================
- Hits       6776    6758   -18     
  Misses      652     652           

Flag	Coverage Δ
unit	91% <92%> (-1%)	⬇️

Impacted Files	Coverage Δ
source/Private/Assert-SetupActionProperties.ps1	98% <92%> (ø)

[pull-request-quantifier-deprecated]

This PR has 251 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Large
Size       : +32 -219
Percentile : 65.1%

Total files changed: 9

Change summary by file extension:
.json : +3 -1
.md : +15 -4
.ps1 : +14 -211
.psd1 : +0 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detected.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

[johlju]

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)