Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect-SQL: Returns clear error message when status is not Online #1841

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 25, 2023

Pull Request (PR) description

  • SqlServerDsc.Common
    • Connect-SQL
      • Now returns a more clear error message when the status of a database
        instance is not Online.

This Pull Request (PR) fixes the following issues

None.

I saw that a pipeline build failed with ScriptHalted instead of a real message.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #1841 (3b2bd39) into main (86869cd) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1841   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        71      71           
  Lines      7313    7327   +14     
====================================
+ Hits       6664    6678   +14     
  Misses      649     649           
Flag Coverage Δ
unit 91% <100%> (+<1%) ⬆️
Impacted Files Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 98% <100%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Jan 25, 2023
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit a461e8a into dsccommunity:main Jan 25, 2023
@johlju johlju deleted the fix/connect-sql branch January 25, 2023 13:47
@johlju johlju removed the needs review The pull request needs a code review. label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant