Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-SqlDscServer: Fix ASSysAdminAccounts and SqlSysAdminAccounts #1863

Merged
merged 3 commits into from
Mar 4, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 4, 2023

Pull Request (PR) description

  • Assert-SetupActionProperties
  • Invoke-SetupAction
    • The parameter SqlSysAdminAccounts is no longer mandatory to allow
      installation where the database engine is not installed.
  • Install-SqlDscServer
    • The parameter SqlSysAdminAccounts is no longer mandatory to allow
      installation where the database engine is not installed.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 4, 2023
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #1863 (d8b4465) into main (58b765c) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1863   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        85      85           
  Lines      7607    7614    +7     
====================================
+ Hits       7005    7012    +7     
  Misses      602     602           
Flag Coverage Δ
unit 92% <100%> (+<1%) ⬆️
Impacted Files Coverage Δ
source/Private/Invoke-SetupAction.ps1 92% <ø> (ø)
source/Public/Install-SqlDscServer.ps1 100% <ø> (ø)
source/Private/Assert-SetupActionProperties.ps1 98% <100%> (+<1%) ⬆️

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit e65a410 into dsccommunity:main Mar 4, 2023
@johlju johlju deleted the fix/issue#1845 branch March 4, 2023 13:05
@johlju johlju removed the needs review The pull request needs a code review. label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install-SqlDscServer: Fails to install when missing ASSysAdminAccounts
1 participant