Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import-SqlDscPreferredModule: Fix checking that SQLPS is loaded #1929

Merged
merged 1 commit into from
May 6, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented May 3, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1929 (4d424cc) into main (753c556) will not change coverage.
The diff coverage is 100%.

❗ Current head 4d424cc differs from pull request most recent head b5e01dd. Consider uploading reports for the commit b5e01dd to get more accurate results

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1929   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        91      91           
  Lines      7788    7788           
====================================
  Hits       7164    7164           
  Misses      624     624           
Flag Coverage Δ
unit 91% <100%> (ø)
Impacted Files Coverage Δ
source/Public/Import-SqlDscPreferredModule.ps1 100% <100%> (ø)

@johlju johlju changed the title Import-SqlDscPreferredModule: Fix checking SQLPS is loaded Import-SqlDscPreferredModule: Fix checking that SQLPS is loaded May 4, 2023
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju force-pushed the fix/issue#1928 branch from 4d424cc to b5e01dd Compare May 6, 2023 09:32
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit d9a84f4 into dsccommunity:main May 6, 2023
@johlju johlju deleted the fix/issue#1928 branch May 6, 2023 09:33
@johlju johlju removed the needs review The pull request needs a code review. label May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SqlScriptQuery: Get-Module for SQLPS throws error
1 participant