-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlServerDsc: More unit tests work cross-platform #1957
SqlServerDsc: More unit tests work cross-platform #1957
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1957 +/- ##
====================================
Coverage 91% 91%
====================================
Files 92 92
Lines 7810 7810
====================================
Hits 7185 7185
Misses 625 625
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
tests/Unit/SqlServerDsc.Common.Tests.ps1
line 494 at r2 (raw file):
} Describe 'SqlServerDsc.Common\Invoke-InstallationMediaCopy' -Tag 'CopyItemWithRobocopy' {
Was changed to wrong command name.
Suggestion:
'InvokeInstallationMediaCopy'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @johlju)
tests/Unit/SqlServerDsc.Common.Tests.ps1
line 494 at r2 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Was changed to wrong command name.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
Pull Request (PR) description
Get-SqlDscPreferredModule
This Pull Request (PR) fixes the following issues
None.
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is