Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Highlight important notes in markdown #1959

Merged
merged 1 commit into from
Aug 17, 2023
Merged

SqlServerDsc: Highlight important notes in markdown #1959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix header in unit tests that referenced the wrong path.
- Fix a path in VS Code workspace settings to correctly use Script Analyzer on
Linux and macOS.
- Updating note comments throughout markdown and generated markdown.
- Highlighted note comments throughout markdown and generated markdown.
- SqlSetup
- Updating a note comment in the README.md.
- Highlighted a note in the README.md.
- SqlMemory
- Highlighted an important note in the README.md.
- SqlMaxDop
- Highlighted an important note in the README.md.

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion source/DSCResources/DSC_SqlMaxDop/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ the number of processors to use in parallel plan execution. Read more about
max degree of parallelism in this article
[Configure the max degree of parallelism Server Configuration Option](https://msdn.microsoft.com/en-us/library/ms189094.aspx)

> [!NOTE]
> [!IMPORTANT]
> This configuration option can also be configured using the DSC
> resource _SqlConfiguration_ but will not allow the dynamic configuration
> as this resource provides. Make sure this value is not configured by both
Expand Down
2 changes: 1 addition & 1 deletion source/DSCResources/DSC_SqlMemory/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ and the default setting for maximum server memory is 2147483647 MB. Read
more about minimum server memory and maximum server memory in this article
[Server Memory Server Configuration Options](https://msdn.microsoft.com/en-us/library/ms178067.aspx).

> [!NOTE]
> [!IMPORTANT]
> These configuration options can also be configured using the DSC
> resource _SqlConfiguration_ but will not allow the dynamic configuration
> as this resource provides. Make sure this value is not configured by both
Expand Down