Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-SqlDscServer: Fix bug for PrepareImage #1961

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 19, 2023

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #1961 (43f1310) into main (22c4f2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1961   +/-   ##
====================================
  Coverage    91%     91%           
====================================
  Files        92      92           
  Lines      7810    7810           
====================================
  Hits       7185    7185           
  Misses      625     625           
Flag Coverage Δ
unit 91% <ø> (ø)
Files Changed Coverage Δ
source/Private/Invoke-SetupAction.ps1 92% <ø> (ø)
source/Public/Install-SqlDscServer.ps1 100% <ø> (ø)

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit f3df24b into dsccommunity:main Aug 20, 2023
@johlju johlju deleted the fix/issue-1960 branch August 20, 2023 09:15
@johlju johlju removed the needs review The pull request needs a code review. label Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install-SqlDscServer with -PrepareImage errors when InstanceName is specified
1 participant