Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRS: Disable integration tests that causes tests to fail (issue #2009) #2008

Merged
merged 3 commits into from
May 5, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented May 4, 2024

Pull Request (PR) description

This re-arranges the change log entries under the unreleased section.

This Pull Request (PR) fixes the following issues

None.

Helps to make releases work until issue #2009 is resolved.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (026647c) to head (67b99f7).

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2008   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        93      93           
  Lines      7862    7862           
====================================
  Hits       7442    7442           
  Misses      420     420           
Flag Coverage Δ
unit 94% <ø> (ø)

@johlju johlju requested a review from a team as a code owner May 5, 2024 09:51
@johlju johlju changed the title Fix CHANGELOG SqlRS: Disable integration tests that causes tests to fail (issue #2009) May 5, 2024
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 3ef838b into dsccommunity:main May 5, 2024
36 checks passed
@johlju johlju deleted the debug-pipeline-fails-sqlrs branch May 5, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant