-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved example Sample_xWebsite_StopDefault out from README.md #499
Conversation
should probably implement #483 first? |
Codecov Report
@@ Coverage Diff @@
## dev #499 +/- ##
=======================================
Coverage 91.39% 91.39%
=======================================
Files 17 17
Lines 2661 2661
=======================================
Hits 2432 2432
Misses 229 229 Continue to review full report at Codecov.
|
This works, we can implement #483 after this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tomlarse)
a discussion (no related file):
Just a tiny comment. Please update the change log with an entry explaining this change,
I will merge PR #500 before this one, I didn't realize you resolved that one too! It's awesome! 😄 |
Would be great if you can take care of the other issues as well. 😃 I will merge PR #500 as soon as the tests pass. There are so many commits pushed so the CI pipeline is behind. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tomlarse)
Examples/Sample_xWebsite_StopDefault.ps1, line 1 at r1 (raw file):
<#
Let us move this file to the correct folder now when PR #500 is merged. :)
merge changes from #500
Will do. I'll do the other ones as well. Do you want separate PR's from each, or can I put all of them here? |
Do as you like. You may put all of them here if you like. |
I think you can just close it now, it seems like the other ones related are already in progress :) |
Ah okay! I'm having a hard time keeping up with the PRs which one resolves what. :) Then I will review this one. But will be tomorrow, it's late here now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved
@tomlarse Thank you for this! |
Pull Request (PR) description
Changes described in #486
This Pull Request (PR) fixes the following issues
fixes #486
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is