Added continuous delivery with a new CI pipeline #549

johlju · 2019-12-28T16:04:45Z

Pull Request (PR) description

Added continuous delivery with a new CI pipeline

This Pull Request (PR) fixes the following issues

Fixes xWebAdministration: Converting to new CI pipeline #547

Task list

Added an entry to the change log under the Unreleased section of the CHANGELOG.md.
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
Resource documentation added/updated in README.md.
Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help.
Comment-based help added/updated.
Localization strings added/updated in all localization files as appropriate.
Examples appropriately added/updated.
Unit tests added/updated. See DSC Resource Testing Guidelines.
Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

PlagueHO

Reviewed 157 of 157 files at r1.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @johlju)

azure-pipelines.yml, line 102 at r1 (raw file):

      - job: Test_Integration
        pool:
          vmImage: 'vs2017-win2016'

Why use a different image for unit vs integration tests?

Resolve-Dependency.psd1, line 2 at r1 (raw file):

@{ # Defaults Parameter value to be loaded by the Resolve-Dependency command (unless set in Bound Parameters)
    #PSDependTarget  = './output/modules'

Maybe remove commented out lines?

source/xWebAdministration.psd1, line 82 at r1 (raw file):

    } # End of PrivateData hashtable
}

Can we remove all this whitespace?

source/en-US/about_xWebAdministration.help.txt, line 5 at r1 (raw file):


SHORT DESCRIPTION
    DSC resources for web servers and components around those.

maybe -> DSC resources for configuring web servers and related components.

source/en-US/about_xWebAdministration.help.txt, line 8 at r1 (raw file):


LONG DESCRIPTION
    This module contains DSC resources for deployment and configuration of web servers and components around those.

maybe -> This module contains DSC resources for deploying and configuring IIS web servers and related components.

source/Modules/xWebAdministration.Common/xWebAdministration.Common.psd1, line 15 at r1 (raw file):

    # Company or vendor of this module
    CompanyName       = 'Dsc Community'

Needs upper case DSC

tests/TestHelper/CommonTestHelper.psm1, line 36 at r1 (raw file):

    $newSelfSignedCertZipPath = Join-Path -Path $OutputPath -ChildPath $newSelfSignedCertZip
    $newSelfSignedCertScriptPath = Join-Path -Path $OutputPath -ChildPath 'New-SelfSignedCertificateEx.ps1'
    if (-not (Test-Path -Path $newSelfSignedCertScriptPath))

Add blank line before

tests/TestHelper/CommonTestHelper.psm1, line 42 at r1 (raw file):

            Remove-Item -Path $newSelfSignedCertZipPath -Force
        }
        Invoke-WebRequest -Uri $newSelfSignedCertURL -OutFile $newSelfSignedCertZipPath

Add blank line before.

tests/Integration/MSFT_XIISLogging.Integration.Tests.ps1, line 21 at r1 (raw file):

Import-Module -Name (Join-Path -Path $PSScriptRoot -ChildPath '..\TestHelper\CommonTestHelper.psm1') -Force

[String] $tempName = "$($script:dscResourceName)_" + (Get-Date).ToString("yyyyMMdd_HHmmss")

FYI, doesn't need the [String] declaration.

tests/Unit/MSFT_xWebAppPoolDefaults.Tests.ps1, line 37 at r1 (raw file):

    InModuleScope $script:dscResourceName {

        Describe "xWebAppPoolDefaults\Get-TargetResource" {

Can be single quotes

tests/Unit/MSFT_xWebAppPoolDefaults.Tests.ps1, line 84 at r1 (raw file):

        }

        Describe "xWebAppPoolDefaults\Test-TargetResource" {

Can be single quotes

tests/Unit/MSFT_xWebAppPoolDefaults.Tests.ps1, line 170 at r1 (raw file):

        }

        Describe "xWebAppPoolDefaults\Set-TargetResource" {

Can be single quotes

johlju

Thank you @PlagueHO!

Reviewable status: 132 of 157 files reviewed, 11 unresolved discussions (waiting on @PlagueHO)

azure-pipelines.yml, line 102 at r1 (raw file):