Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: Choosing certificate with longest remaining validity #633

Merged
merged 3 commits into from
May 22, 2024

Conversation

Joe-Rennert
Copy link
Contributor

@Joe-Rennert Joe-Rennert commented May 22, 2024

Pull Request (PR) description

Update Website resource so that when a subject is specified and multiple matching certificates are found, the resource will use the certificate with the longest remaining validity period based on the "NotAfter" property of the certificate. It also excludes certificates from consideration when they do not have a Private Key available.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof and comment-based
    help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88%. Comparing base (3798530) to head (8f4cf7b).

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #633   +/-   ##
===================================
  Coverage    88%    88%           
===================================
  Files        15     15           
  Lines      1924   1925    +1     
===================================
+ Hits       1697   1698    +1     
  Misses      227    227           
Files Coverage Δ
source/DSCResources/DSC_WebSite/DSC_WebSite.psm1 97% <100%> (+<1%) ⬆️

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Joe-Rennert)

@johlju
Copy link
Member

johlju commented May 22, 2024

@Joe-Rennert great work on the tests! 🙂

@johlju
Copy link
Member

johlju commented May 22, 2024

Will merge as soon as the tests passes, I had to kick them off again because one failed on an unrelated error. 🙂

@johlju johlju added the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label May 22, 2024
@johlju johlju merged commit cfced5c into dsccommunity:main May 22, 2024
11 checks passed
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants