Make copying crash ID simple #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschmidt
approved these changes
Apr 6, 2021
fmoc
pushed a commit
to owncloud/client
that referenced
this pull request
Apr 7, 2021
This enables a "click to copy crash report ID" feature in owncloud_crash_reporter. See dschmidt/libcrashreporter-qt#25 for more information.
fmoc
pushed a commit
to owncloud/client
that referenced
this pull request
Apr 8, 2021
This enables a "click to copy crash report ID" feature in owncloud_crash_reporter. See dschmidt/libcrashreporter-qt#25 for more information.
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements what was suggested in owncloud/client#8130:
The ID is a clickable link. The corresponding click handler copies the ID into the user's clipboard. It seemed like the easiest way to integrate this feature in the current UX, otherwise a button would need to be added somewhere. Alternatives would've been a context menu entry, or making the entire label clickable.
The PR also contains a commit that fixes a CMake policy warning, making the project compatible with the latest CMake releases.
Note that I could not compile the library without patching
breakpad, which used astruct ucontextthat doesn't seem to exist in both the systemucontext.handsys/ucontext.hand the bundled headers. Instead, aucontext_tistypedef'd directly from said struct. In order to make the compiler happy (i.e., provide its full definition), I had to swap all occurrences ofstruct ucontextwithucontext_t. I might have to file a second PR to fix this, but I'm not sure why this only seems to affect my own build.