Skip to content

Commit

Permalink
net-gro: reset skb->truesize in napi_reuse_skb()
Browse files Browse the repository at this point in the history
[ Upstream commit e33d0ba ]

Recycling skb always had been very tough...

This time it appears GRO layer can accumulate skb->truesize
adjustments made by drivers when they attach a fragment to skb.

skb_gro_receive() can only subtract from skb->truesize the used part
of a fragment.

I spotted this problem seeing TcpExtPruneCalled and
TcpExtTCPRcvCollapsed that were unexpected with a recent kernel, where
TCP receive window should be sized properly to accept traffic coming
from a driver not overshooting skb->truesize.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
  • Loading branch information
Eric Dumazet authored and kamalmostafa committed Jun 16, 2014
1 parent 8c96efe commit 86002b7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -3797,6 +3797,7 @@ static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb)
skb->vlan_tci = 0;
skb->dev = napi->dev;
skb->skb_iif = 0;
skb->truesize = SKB_TRUESIZE(skb_end_offset(skb));

napi->skb = skb;
}
Expand Down

0 comments on commit 86002b7

Please sign in to comment.