Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove MimicExplainer #53

Merged
merged 1 commit into from
May 22, 2023
Merged

refactor: remove MimicExplainer #53

merged 1 commit into from
May 22, 2023

Conversation

thatlittleboy
Copy link
Collaborator

Resolves #33 .

As described in the issue, we are prioritizing passing tests and lints first. (Currently, MimicExplainer is a blocker for resolving the F821 (Undefined Name) ruff lint).

After this PR is merged, I will open a follow up issue to "re"-implement MimicExplainer. With a reference back to this PR so we can refer to this code when implementing.

Copy link
Owner

@dsgibbons dsgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MimicExplainer does not work -- deprecate?
2 participants