Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reload button to LiveSPICE VST #212

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

kostoskistefan
Copy link
Contributor

Hello!

I've recently tried LiveSPICE and I find it very cool and very useful. After playing around with some simulations using the VST plugin inside Cockos REAPER, I found myself constantly having to click the Load Schematic button, search for the schematic file and then open it manually after doing some changes to the circuit.

Therefore, this pull request adds a Reload button to the VST, which I think is a much more convenient option to have, instead of manually reloading the schematic file every single time you update the circuit. Additionally, since adding a fourth button made everything look a bit squashed, I did a minor layout update, which you can see on the following image:

LiveSPICE VST GUI Update

Please let me know if you have any comments and/or suggestions about this.

Copy link
Owner

@dsharlet dsharlet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. This makes sense to me and it looks good, aside from minor formatting nits.

@@ -95,9 +96,22 @@ private void ShowAboutButton_Click(object sender, RoutedEventArgs e)
{
About about = new About() { Owner = Window.GetWindow(this) };
about.ShowDialog();
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you have a mix of tabs and spaces here, which is rendering differently than it did in your editor (presumably).

I'm pretty sure we use spaces everywhere, can you reformat using spaces only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how that happened, since I always use spaces. In any case, thanks for noticing. I've fixed the formatting

@@ -3,6 +3,7 @@
using System.IO;
using System.Windows;
using System.Windows.Controls;
using static System.Windows.Forms.VisualStyles.VisualStyleElement.Window;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually used? May have been an accidental intellisense addition? (That happens to me a lot.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right. I installed Visual Studio just to open this project and since I haven't used it in well over 5-6 years, I forgot to check the intellisense additions, which is my bad. I removed the unnecessary line now and everything should be as requested. If you have any other comments, let me know!

@dsharlet dsharlet merged commit 0bab2a3 into dsharlet:master Dec 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants