Skip to content
This repository has been archived by the owner on Oct 15, 2018. It is now read-only.

Replace typeChecker.typeToString with own implementation #204

Closed
dsherret opened this issue Oct 29, 2016 · 1 comment
Closed

Replace typeChecker.typeToString with own implementation #204

dsherret opened this issue Oct 29, 2016 · 1 comment
Labels
code improvement
Milestone
Version 6.2

Comments

@dsherret
Copy link
Owner

The implementation of typeChecker.typeToString keeps changing within typescript's code. It would be better for this library to have it's own type to string so that it's not dependent on whatever the typescript team decides to do.
@dsherret dsherret added this to the Version 6.2 milestone Oct 29, 2016
dsherret added a commit that referenced this issue Nov 11, 2016
@dsherret
#204 - Replace typeChecker.typeToString with own implementation
cd07f44
@dsherret
Copy link
Owner Author

Implemented somewhat of a hybrid solution that still uses the type checker, just not for everything. Unfortunately had to do this because they kept changing the behaviour of typeToString.

dsherret added a commit that referenced this issue Nov 11, 2016
@dsherret
#204 - Fix linting errors
d43f7c1
dsherret added a commit that referenced this issue Nov 13, 2016
@dsherret
#204 - Improvement to writing types.
1c4beb3
dsherret added a commit that referenced this issue Nov 13, 2016
@dsherret
#204 - Amend. More tests
223b62c
@dsherret dsherret mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code improvement
Projects
None yet
Milestone
Version 6.2
Development

No branches or pull requests
1 participant
@dsherret