-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Daylight Saving Time (DST) transition #104
Comments
Too bad that it seems to crash the datalogger. Honestly, I was expecting the backend to fail, not the datalogger. The meters are DST aware it seems, but I got no clue why the datalogger crashes. |
|
Aah I see, the last character in the timestamp marks the DST period. I was wondering what the |
Fixed in #105. More checks tomorrow, datalogger is the most important one.. |
For the next summer to winter transition I will have to signal pytz whether the input time is with or without DST, as the same hour is read twice. It wouldn't have been a problem when the meters used UTC as output, but apparently for some reason they choose not to do so. |
Fixed it in the timestamp input reader, which now both manually sets It already was timezone-aware, but Django formatted it to +1 or +2. PostgreSQL shouldn't care, as it already keeps track of tzinfo, but MySQL might be bugged by it. |
Merged. Next winter's DST transition should be no problem. |
Coming sunday 27th of March is the first DST transition since I've started this project. I've used Django's timezone aware features, but I still have to check:
Since we will be skipping an hour, in the worst case all data of that hour will be lost. Next winter will be more interesting, as the hours drops backwards, potentially overriding existing data when not respecting timezones (MySQL).
The text was updated successfully, but these errors were encountered: