Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD compatibility #1175

Closed
Wieter opened this issue Nov 1, 2020 · 3 comments
Closed

FreeBSD compatibility #1175

Wieter opened this issue Nov 1, 2020 · 3 comments
Milestone

Comments

@Wieter
Copy link

Wieter commented Nov 1, 2020

First of all, thanks for all your work on this neat piece of software!

To increase interoperability over various systems, may I suggest to implement a different shebang for all .sh scripts?

For example, while installing on FreeBSD I had to edit the file:


and replace #!/bin/bash with #!/usr/bin/env bash

Note: at FreeBSD, bash is not installed by default! use pkg install bash

Additionally, in

STATIC_ROOT = '/var/www/dsmrreader/static'
the STATIC_ROOT is statically defined as '/var/www/dsmrreader/static'. As different systems (and users) have different default and preferred locations for www data, it might be a good idea to be able to set/mention this as override parameter (DJANGO_STATIC_ROOT) in the .env(.local) file. In my case I had to set it to /usr/local/www/dsmr/dsmr-reader/static

Now, whenever there is an update, I first have to git reset --hard, then pull, and then re-incorporate above changes.

For the setup configuration in FreeBSD, I think people can manage. It deviates a bit from the documentation and example configs (mostly due to different paths), and I myself prefer to use uwsgi in emperor mode.

@Wieter Wieter added the review Not sure yet whether to implement this label Nov 1, 2020
@dennissiemensma dennissiemensma removed the review Not sure yet whether to implement this label Nov 1, 2020
@dennissiemensma dennissiemensma added this to the 4.6 milestone Nov 1, 2020
@Wieter
Copy link
Author

Wieter commented Nov 1, 2020

Coming back to the STATIC_ROOT, it might be better to set in

STATIC_ROOT = '/var/www/dsmrreader/static'
to something universal like os.path.join(BASE_DIR, 'static')

@dennissiemensma
Copy link
Member

Thanks for reporting! I've updated the shebangs and added an env var (DJANGO_STATIC_ROOT) for overriding STATIC_ROOT. These will be available in v4.6.

@dennissiemensma
Copy link
Member

Uitgebracht in v4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants