Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trends page giving errors (when lacking data) #125

Closed
WatskeBart opened this issue May 1, 2016 · 6 comments
Closed

Trends page giving errors (when lacking data) #125

WatskeBart opened this issue May 1, 2016 · 6 comments
Assignees

Comments

@WatskeBart
Copy link
Contributor

Following error when navigating to /trends
Running release v1.1.1
image

@dennissiemensma
Copy link
Member

dennissiemensma commented May 1, 2016

Hi, thank you for reporting this issue. This will happen when there is no data (yet) to plot trends with.

Could you provide some more information such as:

A snapshot of one your DSMR telegrams (readings)

You should see some data similar to this format: https://github.com/dennissiemensma/dsmr-reader/blob/master/dsmr_datalogger/tests/datalogger/test_landisgyr350_dsmr42.py#L17

What kind of data does your Status-page provide?
Any errors and does your reading count & 'seconds ago' update? (http://dsmr-reader.readthedocs.io/nl/latest/_static/screenshots/status.png)

@WatskeBart
Copy link
Contributor Author

I already suspected that the error was because of lack of data. All other pages are working OK and data is being received.

Maybe implement a check to see if enough data is generated and telling the user there isn't enough data yet to make a trend. The current error could make a user think they did something wrong.
Something like you did on the Archive page:
image

Still what a great application you wrote. I tried too many bad dsmr implementations before I discovered your application. Good stuff, keep it up

@dennissiemensma dennissiemensma added this to the 1.2 milestone May 1, 2016
@dennissiemensma
Copy link
Member

Thank you for your feedback and kind words.

There used to be a check but I suspect the changes for issue #99 (a while back) make it crash before the GUI could render. I will fix the crash as it shouldn't behave in this manner.

Feel free to report other issues or ideas as well. :]

@dennissiemensma dennissiemensma changed the title Trends page giving errors Trends page giving errors (when lacking data) May 1, 2016
@dennissiemensma dennissiemensma self-assigned this May 1, 2016
@dennissiemensma
Copy link
Member

Fixed and added test in commit f2cbbd9. Will be released shortly as patch.

@dennissiemensma
Copy link
Member

dennissiemensma commented May 1, 2016

Patch is available as version 1.1.2.

  • You may update codebase & reload manually.

Or

  • Just use the ./deploy.sh script in the root of this project (run as dsmr user).

Also updated credits: http://dsmr-reader.readthedocs.io/en/latest/credits.html

@WatskeBart
Copy link
Contributor Author

Just updated and looking good!

@dennissiemensma dennissiemensma removed this from the 1.2 milestone May 1, 2016
@dennissiemensma dennissiemensma modified the milestone: 0.0 Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants