Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve the current energycontract for the statistics page #485

Closed
wants to merge 5 commits into from

Conversation

helmo
Copy link
Contributor

@helmo helmo commented Jun 26, 2018

On the statistics page I noticed the following message:
selection_022

This is strange as I had just recently added additional contract data, like:
selection_021

It seems like the code for this was a forgotten todo .... now done.

@codecov-io
Copy link

codecov-io commented Jun 27, 2018

Codecov Report

Merging #485 into development will decrease coverage by 0.03%.
The diff coverage is 80%.

@@               Coverage Diff               @@
##           development     #485      +/-   ##
===============================================
- Coverage          100%   99.96%   -0.04%     
===============================================
  Files              102      102              
  Lines             2523     2528       +5     
  Branches           209      211       +2     
===============================================
+ Hits              2523     2527       +4     
- Partials             0        1       +1

@dennissiemensma
Copy link
Member

Bedankt voor je alertheid! Dit is regressie van #390 en zat er voorheen in. Echter door het verplaatsen van code werkt dit niet meer en is het me niet opgevallen.

Ik zal de code terugzetten en meteen er een test voor maken. Toch bedankt voor je patch. :]

@dennissiemensma
Copy link
Member

Opgelost in 6037c1c voor de volgende release.

@dennissiemensma
Copy link
Member

Uitgebracht in nieuwe release: https://github.com/dennissiemensma/dsmr-reader/releases/tag/v1.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants