Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate env in registry_auth #1540

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

r4victor
Copy link
Collaborator

Closes #1539

This PR makes the env context available in registry_auth of run configurations via ${{ env.ENV_NAME }} syntax. This allows passing registry_auth without specifying registry creds in configuration files:

type: task
image: my_registry/private_image
env:
  - REGISTRY_USER
  - REGISTRY_PASSWORD
registry_auth:
  username: ${{ env.REGISTRY_USER }}
  password: ${{ env.REGISTRY_PASSWORD }}

The interpolation is implemented on the client side. The support for specifying sensitive values without interpolation is to be addressed by #708.

@r4victor r4victor merged commit 4976572 into master Aug 12, 2024
12 of 14 checks passed
@r4victor r4victor deleted the issue_1539_interpolate_env branch August 12, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support env interpolation in YAML
1 participant