Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Plotter Labels #1071

Merged
merged 7 commits into from
Sep 2, 2024
Merged

Conversation

gawebb-dstl
Copy link
Contributor

@gawebb-dstl gawebb-dstl commented Aug 2, 2024

Replaced 'truths_label', 'measurements_label', 'track_label' and 'sensor_label' with 'label' for all of the plotters.

This simplifies using the plot_### functions. To avoid breaking changes, the individual labels (e.g. 'truths_label') can still be used.

Make the Measurement Label for Plotters Consistent

For some plotters the measurement legend would add 'clutter' or 'detections' to end of the measure label. For other plotters it wouldn't.

@gawebb-dstl gawebb-dstl changed the title Make the Measurement Label for Plotters Consistent Update Plotter Labels Aug 15, 2024
@gawebb-dstl gawebb-dstl marked this pull request as ready for review August 15, 2024 14:09
@gawebb-dstl gawebb-dstl requested a review from a team as a code owner August 15, 2024 14:09
@gawebb-dstl gawebb-dstl requested review from sdhiscocks and akenyon and removed request for a team August 15, 2024 14:09
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (4b6bd37) to head (c28b99a).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1071      +/-   ##
==========================================
+ Coverage   94.31%   94.49%   +0.17%     
==========================================
  Files         208      208              
  Lines       13603    13633      +30     
  Branches     2767     2773       +6     
==========================================
+ Hits        12830    12882      +52     
+ Misses        522      506      -16     
+ Partials      251      245       -6     
Flag Coverage Δ
integration 67.24% <88.15%> (+0.05%) ⬆️
unittests 91.03% <98.68%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gawebb-dstl gawebb-dstl marked this pull request as draft August 16, 2024 12:49
Changed measurement labels in stonesoup/plotter.py for matplotlib plotters
@gawebb-dstl gawebb-dstl marked this pull request as ready for review August 16, 2024 15:38
@gawebb-dstl
Copy link
Contributor Author

I've changed ###_label to label in all the examples, however it wasn't required.

@sdhiscocks sdhiscocks merged commit b24b5a2 into main Sep 2, 2024
10 checks passed
@sdhiscocks sdhiscocks deleted the consistent_measurement_label_for_plotters branch September 2, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants