Sensor performance improvement #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhiscocks
added
the
breaking
sdhiscocks
requested review from
jswright-dstl,
orosoman-dstl and
akenyon
and removed request for
a team
By passing a measurement mode to is_detectable, this avoids unnecessary recreation of a model for every truth. Where a different model is needed, still try to use the parameters of the sensor model in order to minimise calculations.
sdhiscocks
force-pushed
the
sensor_man_perf
branch
from
25a1697 to
8f12b80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
- Coverage 94.49% 94.41% -0.09%
==========================================
Files 209 209
Lines 13771 13786 +15
Branches 2799 2808 +9
==========================================
+ Hits 13013 13016 +3
- Misses 508 515 +7
- Partials 250 255 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jswright-dstl
approved these changes
Sep 30, 2024
akenyon
approved these changes
Oct 1, 2024
gawebb-dstl
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes speed up some sensor management examples around x3
measurement_modeltois_detectableinSimpleSensorThis includes a breaking change, where anything sub classing from
SimpleSensorwill need to addmeasurement_modelargument tois_detectablemethod (even if not using it).