feat(LaunchPad): Save state of presets when switching #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dszakallas
force-pushed
the
persistent-jumpset
branch
from
2a8fa51
to
1e98ab9
Compare
dszakallas
changed the title
dszakallas
changed the title
dszakallas
force-pushed
the
persistent-jumpset
branch
from
1e98ab9
to
1d3e9a5
Compare
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preset state save/restore functionality to launchpad App. Main motivation is to enable recalling the set of loop and beatjumps after they were modified. Currently if user changes the set of loopjumps for a laid out preset, once the preset is removed by a layout update, its state is lost. This PR changes that.
Also renames
modetobouncefor loopjump and beatjump controls and exposes them as parameter.