This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Added option to use AWS bundled ca cert Fixes #171 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ class CLI < Thor | |||
| class_option :tfstate, type: :boolean, desc: "Generate tfstate" | |||
| class_option :profile, type: :string, desc: "AWS credentials profile" | |||
| class_option :region, type: :string, desc: "AWS region" | |||
| class_option :"aws-use-bundled-cert", type: :boolean , desc: "Use the bundled CA certificate from AWS SDK" | |||
There was a problem hiding this comment.
[rubocop]
- Space found before comma.
- Line is too long. [109/80] :ref
…forming into cert-bundle-fix
| @@ -5,6 +5,9 @@ class CLI < Thor | |||
| class_option :tfstate, type: :boolean, desc: "Generate tfstate" | |||
| class_option :profile, type: :string, desc: "AWS credentials profile" | |||
| class_option :region, type: :string, desc: "AWS region" | |||
| class_option :"aws-use-bundled-cert", | |||
There was a problem hiding this comment.
class_option :use_bundled_cert looks better.
Underscores are converted to hyphens automatically.
[--use-bundled-cert], [--no-use-bundled-cert] # Use the bundled CA certificate from AWS SDK
|
Sorry for late review 🙇 IMO |
| response = http.get(uri) | ||
|
|
||
| unless response.code == "200" | ||
| raise "Error downloading Lambda Code HTTP Res Code #{response.code} from #{url}" |
There was a problem hiding this comment.
[rubocop]
- Line is too long. [92/80] :ref
|
ugh was working on another branch to add lambda support, must have committed to the wrong branch. |
…an/terraforming into cert-bundle-fix" This reverts commit ffad1a6, reversing changes made to 51f4cae.
…an/terraforming into cert-bundle-fix" This reverts commit 51f4cae, reversing changes made to f9e7d91.
|
ok, all better.. removed aws- prefix.. |
| @@ -5,6 +5,9 @@ class CLI < Thor | |||
| class_option :tfstate, type: :boolean, desc: "Generate tfstate" | |||
| class_option :profile, type: :string, desc: "AWS credentials profile" | |||
| class_option :region, type: :string, desc: "AWS region" | |||
| class_option :"use-bundled-cert", | |||
|
Just one more thing, please update README. There is still |
| @@ -68,7 +68,7 @@ $ terraforming s3 --profile hoge | |||
| You can force the AWS SDK to utilize the CA certificate that is bundled with the SDK for systems where the default OpenSSL certificate is not installed (e.g. Windows) by utilizing the `--aws-use-bundled-cert` option. | |||
|
LGTM 👍 Thanks ❗ |
|
Thanks @dtan4! Sorry for making you triple check this. |
|
No problem 👌 ❗ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.