This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Support KMS key #299
Merged
Support KMS key #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtan4
commented
Jan 11, 2017
| end | ||
|
|
||
| def keys | ||
| @client.list_keys.keys.reject { |key| managed_master_key?(key) }.map { |key| @client.describe_key(key_id: key.key_id) }.map(&:key_metadata) |
There was a problem hiding this comment.
[rubocop]
- Line is too long. [147/140] :ref
dtan4
commented
Jan 11, 2017
| def key_policy_of(key) | ||
| policies = @client.list_key_policies(key_id: key.key_id).policy_names | ||
|
|
||
| return "" if policies.length == 0 |
There was a problem hiding this comment.
[rubocop]
- Use
empty?instead oflength == 0.
dtan4
commented
Jan 11, 2017
| end | ||
|
|
||
| def key_usage_of(key) | ||
| key.key_usage.gsub("_", "/") |
There was a problem hiding this comment.
[rubocop]
- Use
trinstead ofgsub. :ref
dtan4
commented
Jan 11, 2017
| end | ||
|
|
||
| def key_usage_of(key) | ||
| key.key_usage.gsub("_", "/") |
There was a problem hiding this comment.
[rubocop]
- Use
trinstead ofgsub. :ref
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #278
WHAT
Support
aws_kms_keyresource. Command isterraforming kmsk.REF
AWS: aws_kms_key - Terraform by HashiCorp