Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adding Orchestration API #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rkday
Copy link
Contributor

@rkday rkday commented Nov 17, 2019

I'm starting to add the OpenStack Orchestration (Heat) API. It's far from finished (I need to add src/orchestration/api.rs before it even compiles) but I wanted to open a PR to allow early feedback/others to contribute.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 17, 2019

Build failed.

Copy link
Owner

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

@@ -0,0 +1,58 @@
// Copyright 2018 Dmitry Tantsur <divius.inside@gmail.com>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put your copyright here or just skip the copyright completely.

@@ -0,0 +1,190 @@
// Copyright 2017 Dmitry Tantsur <divius.inside@gmail.com>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar re copyrights

/// Start creating a server.
pub(crate) fn new(session: Rc<Session>, name: String) -> NewStack {
NewServer {
// session,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, you surely need it on line 60

@wangxiyuan
Copy link

recheck

@theopenlab-ci
Copy link

theopenlab-ci bot commented Jan 2, 2020

Build failed.

@draane
Copy link

draane commented Mar 3, 2022

Hi, I need the Orchestration API feature and I can probably implement it.
Should I open a new pull request?

@dtantsur
Copy link
Owner

dtantsur commented Apr 5, 2024

@rkday @draane any of you want to continue this? It's pity that the patch is semi-abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants