Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatible with deny(unsafe_op_in_unsafe_fn) #1281

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Make compatible with deny(unsafe_op_in_unsafe_fn) #1281

merged 2 commits into from
Oct 28, 2023

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Oct 28, 2023

Closes #1191.

@dtolnay
Make compatible with deny(unsafe_op_in_unsafe_fn)
b5b2fcd
@dtolnay
Ignore spurious unused_unsafe produced by old compilers
4a9c24b 
    warning: unnecessary `unsafe` block
      --> demo/src/main.rs:22:63
       |
    22 |         fn new_blobstore_client() -> UniquePtr<BlobstoreClient>;
       |                                                               ^
       |                                                               |
       |                                                               unnecessary `unsafe` block
       |                                                               because it's nested under this `unsafe` fn
       |
       = note: `#[warn(unused_unsafe)]` on by default
       = note: this `unsafe` block does contain unsafe operations, but those are already allowed in an `unsafe fn`
       = note: `#[allow(unsafe_op_in_unsafe_fn)]` on by default
@dtolnay dtolnay merged commit d15c97b into master Oct 28, 2023
29 checks passed
@dtolnay dtolnay deleted the unsafeop branch October 28, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use unsafe blocks in unsafe fns
1 participant
@dtolnay